Rework target checking for built-in attributes #145085

JonathanBrouwer · 2025-08-08T09:41:48Z

This is a refactoring of target checking for built-in attributes.
This PR has the following goals:

Only refactor the 80% of the attributes that are simple to target check. More complicated ones like #[repr] will be in a future PR. Tho I have written the code in such a way that this will be possible to add in the future.
No breaking changes.
- This part of the codebase is not very well tested though, we can do a crater run if we want to be sure.
- I've spotted quite a few weird situations (like I don't think an impl block should be deprecated?). We can propose fixing these to in a future PR

I've split it in commits and left a description on some of the commits to help review.
r? @jdonszelmann

rustbot · 2025-08-09T19:05:15Z

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-08-09T19:06:34Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

compiler/rustc_attr_parsing/src/attributes/link_attrs.rs

compiler/rustc_attr_parsing/src/attributes/deprecation.rs

tests/ui/deprecation/deprecation-sanity.stderr

tests/ui/issues/issue-31769.stderr

tests/ui/lang-items/issue-83471.stderr

rustbot · 2025-08-10T13:02:39Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

Zalathar · 2025-08-13T12:23:35Z

If a PR is hard to merge due to repeated bitrot, we can always resort to a priority boost.

jdonszelmann · 2025-08-13T12:49:57Z

ok, sounds good. Let's merge this ASAP with some p then? Then it merges before that rollup. I'll preemptively remake the rollup without the conflicting pr

@bors r+ rollup=never p=1

bors · 2025-08-13T12:50:00Z

📌 Commit 7a85aa9 has been approved by jdonszelmann

It is now in the queue for this repository.

Rework target checking for built-in attributes This is a refactoring of target checking for built-in attributes. This PR has the following goals: - Only refactor the 80% of the attributes that are simple to target check. More complicated ones like `#[repr]` will be in a future PR. Tho I have written the code in such a way that this will be possible to add in the future. - No breaking changes. - This part of the codebase is not very well tested though, we can do a crater run if we want to be sure. - I've spotted quite a few weird situations (like I don't think an impl block should be deprecated?). We can propose fixing these to in a future PR Fixes #143780 Fixes #138510 I've split it in commits and left a description on some of the commits to help review. r? `@jdonszelmann`

bors · 2025-08-13T13:48:21Z

⌛ Testing commit 7a85aa9 with merge 5477855...

bors · 2025-08-13T13:50:41Z

💔 Test failed - checks-actions

jdonszelmann · 2025-08-13T13:59:00Z

@bors r+

spurious failure

bors · 2025-08-13T13:59:02Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Rollup of 9 pull requests #145351

bors · 2025-08-13T13:59:03Z

📌 Commit 7a85aa9 has been approved by jdonszelmann

It is now in the queue for this repository.

Rework target checking for built-in attributes This is a refactoring of target checking for built-in attributes. This PR has the following goals: - Only refactor the 80% of the attributes that are simple to target check. More complicated ones like `#[repr]` will be in a future PR. Tho I have written the code in such a way that this will be possible to add in the future. - No breaking changes. - This part of the codebase is not very well tested though, we can do a crater run if we want to be sure. - I've spotted quite a few weird situations (like I don't think an impl block should be deprecated?). We can propose fixing these to in a future PR Fixes #143780 Fixes #138510 I've split it in commits and left a description on some of the commits to help review. r? `@jdonszelmann`

bors · 2025-08-13T14:45:33Z

⌛ Testing commit 7a85aa9 with merge 85f0a70...

bors · 2025-08-13T15:46:57Z

💔 Test failed - checks-actions

- Added a few more variants which are needed for various attributes - Previously a trait method with default block had the same target representation as a method in a `impl trait for` block, this has been changed (See `MethodKind`) - Added `plural_name` for more precision on the form of the name

Every acceptor gets an `ALLOWED_TARGETS` specification which can specify per target whether it is allowed, warned, or errored.

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the target_checking branch 2 times, most recently from 66feb37 to a1c6f2a Compare August 9, 2025 18:02

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the target_checking branch from a1c6f2a to df39f8d Compare August 9, 2025 18:56

rustbot assigned jdonszelmann Aug 9, 2025

JonathanBrouwer marked this pull request as ready for review August 9, 2025 19:06

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2025

JonathanBrouwer commented Aug 9, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/link_attrs.rs Outdated Show resolved Hide resolved

JonathanBrouwer commented Aug 9, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/deprecation.rs Show resolved Hide resolved

JonathanBrouwer commented Aug 9, 2025

View reviewed changes

tests/ui/deprecation/deprecation-sanity.stderr Show resolved Hide resolved

JonathanBrouwer commented Aug 9, 2025

View reviewed changes

tests/ui/issues/issue-31769.stderr Outdated Show resolved Hide resolved

JonathanBrouwer commented Aug 9, 2025

View reviewed changes

tests/ui/lang-items/issue-83471.stderr Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the target_checking branch from df39f8d to c1958d7 Compare August 10, 2025 09:53

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the target_checking branch from c1958d7 to 166a734 Compare August 10, 2025 13:02

JonathanBrouwer force-pushed the target_checking branch from 166a734 to 85f8262 Compare August 10, 2025 13:22

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the target_checking branch from 85f8262 to dcd4b10 Compare August 10, 2025 15:08

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the target_checking branch from dcd4b10 to dd87861 Compare August 10, 2025 15:52

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025

jdonszelmann mentioned this pull request Aug 13, 2025

Port #[custom_mir(..)] to the new attribute system #145206

Open

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2025

JonathanBrouwer added 6 commits August 14, 2025 09:43

Pass the target type down to parse_attribute_list

eb9e953

Allow attribute parsers to specify a list of allowed targets

edfe98c

Every acceptor gets an `ALLOWED_TARGETS` specification which can specify per target whether it is allowed, warned, or errored.

Specify the list of allowed targets per attribute

eaf4c4e

Remove the old target checking logic

47944ca

Update uitests

4ded0e3

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the target_checking branch from 7a85aa9 to 4ded0e3 Compare August 14, 2025 07:55

Rework target checking for built-in attributes #145085

Are you sure you want to change the base?

Rework target checking for built-in attributes #145085

Uh oh!

Conversation

JonathanBrouwer commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rustbot commented Aug 9, 2025

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Zalathar commented Aug 13, 2025

Uh oh!

jdonszelmann commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

jdonszelmann commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 13, 2025

Uh oh!

This comment has been minimized.

bors commented Aug 13, 2025

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 8, 2025 •

edited

Loading